kotlin-jdsl icon indicating copy to clipboard operation
kotlin-jdsl copied to clipboard

[ISSUE-776] add selectFrom spec

Open kihwankim opened this issue 1 year ago • 3 comments

Motivation

  • queryDSL's selectFrom function

Modifications

  • add selectFrom spec in kotlinJdsl

Result

  • Users no longer need to call the select() and from() functions respectively when they query one entity information
       authorRepository.findAll {
            selectFrom(
                entity(Author::class),
                leftJoin(BookAuthor::class).on(path(Author::authorId).equal(path(BookAuthor::authorId))),
            ).where(
                path(BookAuthor::authorId).isNull(),
            ).orderBy(
                path(Author::authorId).asc(),
            )
        }

Closes

  • #776

kihwankim avatar Oct 04 '24 12:10 kihwankim

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.73%. Comparing base (565e71b) to head (19d48aa). Report is 52 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #777   +/-   ##
========================================
  Coverage    91.73%   91.73%           
========================================
  Files          337      337           
  Lines         3447     3449    +2     
  Branches       209      209           
========================================
+ Hits          3162     3164    +2     
  Misses         223      223           
  Partials        62       62           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 04 '24 12:10 codecov-commenter

Thank you for your contribution. The feature you added is a basic feature of JPQL and seems very useful.

However, since it is a new feature added to JDSL, it would be better to add it under the manual, docs. Please also work on the manual.

--- korean 기여해주셔서 고맙습니다. 추가해주신 기능은 JPQL에서 기본적으로 되던 기능으로 매우 유용해 보입니다.

다만 JDSL 에서 새로운 기능이 추가된 것이므로 메뉴얼인 docs 아래에 추가 되는게 좋을 것 같습니다. 메뉴얼 작업도 함께 부탁드리겠습니다.

cj848 avatar Oct 05 '24 21:10 cj848

@cj848 Thank you for the review. I added it to the manual.

--- korean 리뷰 감사합니다 메뉴얼에 추가했습니다.

kihwankim avatar Oct 06 '24 05:10 kihwankim