open-text-embeddings icon indicating copy to clipboard operation
open-text-embeddings copied to clipboard

Published 20 hours ago • verified publisher icon limcheekin

Modal.com is now supported

Open HawkClaws opened this issue 1 year ago • 2 comments

Modal.com is now supported Please review!

HawkClaws avatar Jan 04 '24 10:01 HawkClaws

Apply Sweep Rules to your PR?

  • [ ] Apply: All new business logic should have corresponding unit tests.
  • [ ] Apply: Refactor large functions to be more modular.
  • [ ] Apply: Add docstrings to all functions and file headers.

sweep-ai-deprecated[bot] avatar Jan 04 '24 10:01 sweep-ai-deprecated[bot]

Great! Thanks for sending the PR, I will review it.

limcheekin avatar Jan 04 '24 10:01 limcheekin

I just review your code, unfortunately it will not works, hence I implemented new one and updated readme: https://github.com/limcheekin/open-text-embeddings/blob/main/open/text/embeddings/server/modal.py https://github.com/limcheekin/open-text-embeddings/blob/main/.github/workflows/deploy-modal.yml

limcheekin avatar Jul 13 '24 06:07 limcheekin