Add Experimental Endorsement Signalling

[carlaKC]

This PR adds the ability for LND to set and relay an experimental range endorsement field with UpdateAddHTLC.

Fixes #7883.

~~Depends on #9049, uses custom records added to payload descriptor!~~

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

• llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[carlaKC]

Updated to depend on some of the new APIS, depends on #8660 so only the last 4 commits are relevant.

[carlaKC]

Opening this up for a high level conceptual review - code now matches what's outlined in the blip.

[carlaKC]

Updated feature bit values to match update to blip.

[PurpleTimez]

@carlaKC If you have time to have a look on this review comment. I don't know if it's an issue with the PR or the blip, I think it's more the PR implementation which sounds incorrect (apologies if I'm wrong).

[carlaKC]

Updated w/ suggested changes!

Sadly does need to depend on the mega-PR because we require the CustomRecords that are surfaces for incoming UpdateAddHTLCs TLCs.

CI failures all belong to the upstream PR (afaik, looking into them!). Since that one is going to take some time to get in, I'm going to old off on rebase so until it's closer to merge.

[guggero]

@carlaKC I'm going to split the mega-PR up into smaller pieces, but only one at a time to keep the amount of rebase work at a manageable level. I think the commits you need are in PART2, which should be extracted some time next week.

[carlaKC]

Thanks for the review ya'll! Just waiting on part #2 to be split off of mega-pr then I'll rebase + address 👍

[carlaKC]

Rebased on #9049 and changed base branch to get rid of the 130 commits :')

Will update to master once dependent PR is in!

[guggero]

Oops, deleted the branch too quickly, sorry.

[carlaKC]

Rebased on master!

[ellemouton]

needs rebase and then we g2g I think

[lightninglabs-deploy]

@ellemouton: review reminder @carlakc, remember to re-request review from reviewers when ready