lnd icon indicating copy to clipboard operation
lnd copied to clipboard

route: Add onion blob to sendtoroute

Open ErikEk opened this issue 3 years ago • 2 comments

This PR adds the ability to parse a custom onion blob to sendtoroute. The blob is limited to 1366 bytes for now. Partly closes #6206:

  • [x] Add a new OnionBlob field to the SendToRoute RPC call. If present, normal path to onion blob compilation can be skipped.
  • [ ] Add a similar field to SendPaymentV2. In this case path finding should be skipped all together and the onion blob used in place. Note that since we can't decode the error retries as we handle them today aren't possible. Instead we may need some custom retry hooks, or just decide that this feature will be only added to SendToRoute.
  • [ ] Create provisions in the current APIs to allow for delegated error processing, if we wish to propagate any learnings from the path finding attempt into the internal mission control store.

ErikEk avatar Jul 18 '22 19:07 ErikEk

@yyforyongyu: review reminder @bitromortac: review reminder

lightninglabs-deploy avatar Sep 12 '22 01:09 lightninglabs-deploy

@bitromortac Thank for letting me know. I'll get back to you.

ErikEk avatar Oct 09 '22 11:10 ErikEk

@erikek, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Nov 14 '22 06:11 lightninglabs-deploy

This is up for grab, right now, if anyone wants to continue the work.

ErikEk avatar Mar 06 '23 15:03 ErikEk

!lightninglabs-deploy mute

Disabling the bot until more work is added here.

bitromortac avatar Mar 14 '23 10:03 bitromortac

@erikek, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar May 02 '23 04:05 lightninglabs-deploy

!lightninglabs-deploy mute 30d

yyforyongyu avatar May 04 '23 00:05 yyforyongyu

Hi @ErikEk, The LSPSpec LSPS2 might require sending custom onions. Can you give me an update on the state of this PR?

Thanks Sev

SeverinAlexB avatar Jul 20 '23 04:07 SeverinAlexB

This is up for grab, right now, if anyone wants to continue the work.

Hi, I did abandon this pr.

ErikEk avatar Jul 20 '23 04:07 ErikEk

@SeverinAlexB feel free to take over the PR if you're interested. Going to close it, the state should be pretty clear from the title and the tags.

guggero avatar Jul 20 '23 10:07 guggero