taproot-assets icon indicating copy to clipboard operation
taproot-assets copied to clipboard

build: update CI+release version to Go 1.25.2

Open Roasbeef opened this issue 1 month ago • 3 comments

We also update the version pinned in the go.mod files to Go 1.24.8.

Roasbeef avatar Oct 10 '25 11:10 Roasbeef

Summary of Changes

Hello @Roasbeef, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the Go language versions utilized throughout the project's development and build infrastructure. It upgrades the Go version for all Docker-based build environments and the primary Makefile to Go 1.25.2, ensuring that the project benefits from the latest stable Go release for its compilation and testing processes. Concurrently, the minimum Go version declared in the project's go.mod files has been advanced to Go 1.24.8, aligning module requirements with a more recent and stable patch release of the Go 1.24 series.

Highlights

  • Go Version Update for CI/Build: The Go version used for building, CI, and Docker images has been updated from 1.24.6 to 1.25.2 across various Dockerfiles and the Makefile.
  • Go Module Requirement Update: The minimum Go version specified in the go.mod files for the main module and sub-modules has been updated from 1.24.6 to 1.24.8.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/main.yaml
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 10 '25 11:10 gemini-code-assist[bot]

Pull Request Test Coverage Report for Build 18405332273

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28010 unchanged lines in 195 files lost coverage.
  • Overall coverage decreased (-15.0%) to 34.621%

Files with Coverage Reduction New Missed Lines %
universe/supplyverifier/util.go 1 98.75%
proof/util.go 2 81.63%
tapdb/migrations.go 2 76.19%
address/log.go 3 0.0%
commitment/log.go 3 0.0%
internal/pedersen/commitment.go 3 95.31%
lndservices/log.go 3 0.0%
rfq/log.go 3 0.0%
tapchannel/log.go 3 0.0%
tapdb/supply_syncer.go 3 73.85%
<!-- Total: 28010
Totals Coverage Status
Change from base Build 18359865357: -15.0%
Covered Lines: 30550
Relevant Lines: 88240

💛 - Coveralls

coveralls avatar Oct 10 '25 12:10 coveralls

@roasbeef, remember to re-request review from reviewers when ready

lightninglabs-deploy avatar Nov 24 '25 14:11 lightninglabs-deploy