rust-lightning
rust-lightning copied to clipboard
[Custom Transactions] Define the `TxBuilder` trait
[Custom Transactions] Define the `TxBuilder` trait
This trait will give users of LDK the ability to create arbitrary
commitment transactions given a snapshot of the Lightning state machine.
For now, we only make it available for internal use. Once further
work elsewhere in LDK is complete, this trait will become public.
👋 Hi! I see this is a draft PR. I'll wait to assign reviewers until you mark it as ready for review. Just convert it out of draft status when you're ready for review!
@TheBlueMatt I believe we are at a good point where we can define this API internally. Still much work to do before making this public, but I thought we could get this done now let me know.
Codecov Report
Attention: Patch coverage is 86.97917% with 25 lines in your changes missing coverage. Please review.
Project coverage is 89.38%. Comparing base (
559a784) to head (3a2f8c9). Report is 11 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lightning/src/ln/channel.rs | 53.70% | 25 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #3761 +/- ##
==========================================
+ Coverage 89.14% 89.38% +0.24%
==========================================
Files 157 158 +1
Lines 123997 126674 +2677
Branches 123997 126674 +2677
==========================================
+ Hits 110531 113227 +2696
- Misses 10786 10818 +32
+ Partials 2680 2629 -51
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
API is not stable yet I am still making big changes to it. Will reopen soon.