rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Bump `electrum_client` dependency and add new TLS-backend features

Open tnull opened this issue 10 months ago • 5 comments

We bump our electrum_client dependency to v0.22 which is the newest version and also aligns with recent BDK releases.

Also, recently rustls introduced a new default crypto provider in aws-lc-rc. Since there have been reports on this new provider not building properly on certain platforms electrum-client introduced additional features allowing the user to configure what backend to use for TLS.

Here, we simply re-expose these features to our users, which also mirrors what we do for Esplora already. Note we avoid changing the behavior of the pre-existing electrum feature to make this a backwards compatible change.

tnull avatar Feb 04 '25 10:02 tnull

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.00%. Comparing base (43de15e) to head (ab0537f). Report is 75 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3587      +/-   ##
==========================================
+ Coverage   89.20%   91.00%   +1.79%     
==========================================
  Files         155      156       +1     
  Lines      119229   135548   +16319     
  Branches   119229   135548   +16319     
==========================================
+ Hits       106363   123358   +16995     
+ Misses      10266     9715     -551     
+ Partials     2600     2475     -125     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Feb 04 '25 10:02 codecov[bot]

Draft for now as in dependency hell :(

tnull avatar Feb 04 '25 11:02 tnull

Blocked on https://github.com/rust-bitcoin/corepc/pull/111

tnull avatar Mar 26 '25 14:03 tnull

Discussed with @tnull and we concluded its probably fine to just do a patch for ldk-node release and we can skip backporting this (which technically breaks compat).

TheBlueMatt avatar Apr 28 '25 18:04 TheBlueMatt

Discussed with @tnull and we concluded its probably fine to just do a patch for ldk-node release and we can skip backporting this (which technically breaks compat).

Right, I can probably do without the backport for now. Would still be great to land this PR though.

tnull avatar Apr 29 '25 07:04 tnull

Going ahead landing this as it has two ACKs, and only the commit message of the last commit was adjusted since.

tnull avatar May 07 '25 12:05 tnull