rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Bitcoin 0.32.2 upgrade

Open arik-so opened this issue 1 year ago • 2 comments

As the title suggests, but still unfortunately a work in progress.

arik-so avatar Aug 13 '24 21:08 arik-so

Codecov Report

Attention: Patch coverage is 82.44804% with 76 lines in your changes missing coverage. Please review.

Project coverage is 90.39%. Comparing base (5ab40b2) to head (36b484a). Report is 48 commits behind head on main.

Files Patch % Lines
lightning/src/offers/invoice.rs 57.14% 0 Missing and 9 partials :warning:
lightning/src/io/mod.rs 77.77% 6 Missing and 2 partials :warning:
lightning/src/routing/router.rs 0.00% 7 Missing :warning:
lightning/src/util/sweep.rs 12.50% 6 Missing and 1 partial :warning:
lightning-rapid-gossip-sync/src/processing.rs 25.00% 0 Missing and 6 partials :warning:
lightning/src/util/ser.rs 87.23% 2 Missing and 4 partials :warning:
lightning/src/chain/onchaintx.rs 50.00% 5 Missing :warning:
lightning/src/events/bump_transaction.rs 33.33% 3 Missing and 1 partial :warning:
lightning-invoice/src/lib.rs 84.21% 3 Missing :warning:
lightning-persister/src/fs_store.rs 62.50% 3 Missing :warning:
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3239      +/-   ##
==========================================
+ Coverage   89.75%   90.39%   +0.63%     
==========================================
  Files         123      124       +1     
  Lines      102158   107249    +5091     
  Branches   102158   107249    +5091     
==========================================
+ Hits        91695    96947    +5252     
+ Misses       7773     7717      -56     
+ Partials     2690     2585     -105     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 13 '24 23:08 codecov[bot]

We'll probably end up with a handful of followups to upstream stuff to bitcoin-io/drop our usage of Cursor/remove no-std features, but they can be in a followup.

TheBlueMatt avatar Aug 14 '24 20:08 TheBlueMatt