rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Add PersistClaimInfo and ClaimInfoRequest events

Open G8XSU opened this issue 1 year ago • 3 comments

Based on #3057

Introduce two new events i.e. PersistClaimInfo and ClaimInfoRequest.

PersistClaimInfo: Indicates that [ClaimInfo] should be durably persisted.

ClaimInfoRequest: Used to request [ClaimInfo] for a specific counterparty commitment transaction.

This PR is still in progress as event writing changes are pending and is not in mergeable state but the api and interface can still be reviewed. Mostly ignore docs, they should be legible but need some more work.

As part of https://github.com/lightningdevkit/rust-lightning/issues/3049

G8XSU avatar May 16 '24 00:05 G8XSU

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 89.70%. Comparing base (50d21b7) to head (7fad4ee). Report is 357 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/events/mod.rs 0.00% 19 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   89.75%   89.70%   -0.06%     
==========================================
  Files         122      122              
  Lines      101791   101810      +19     
  Branches   101791   101810      +19     
==========================================
- Hits        91367    91327      -40     
- Misses       7743     7795      +52     
- Partials     2681     2688       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 16 '24 00:05 codecov-commenter

Also, please include at least a bit of detail in the commit messages.

TheBlueMatt avatar Aug 06 '24 18:08 TheBlueMatt

This needs a rebase now.

tnull avatar Aug 08 '24 12:08 tnull

Merging this into #3106 as per feedback. Addressed most of the comments here, some might be unanswered. Will move some questions to 3106, and close the rest here.

G8XSU avatar Aug 28 '24 20:08 G8XSU

Merging this into #3106 as per feedback.

Should this PR get closed then?

tnull avatar Aug 29 '24 07:08 tnull

Yes i will close this after answering some comments or moving them to new pr.

G8XSU avatar Aug 29 '24 07:08 G8XSU