rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Add more information to OpenChannelRequest Event

Open benthecarman opened this issue 1 year ago • 3 comments

Noticed it was missing is_public and figured could just add all the fields since this isn't serialized.

benthecarman avatar Apr 25 '24 03:04 benthecarman

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.73%. Comparing base (a76ec06) to head (eb47656).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3019      +/-   ##
==========================================
- Coverage   89.80%   89.73%   -0.07%     
==========================================
  Files         122      122              
  Lines      101621   101634      +13     
  Branches   101621   101634      +13     
==========================================
- Hits        91261    91206      -55     
- Misses       7674     7730      +56     
- Partials     2686     2698      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 25 '24 03:04 codecov-commenter

Msrv strikes again 😭

benthecarman avatar Apr 25 '24 05:04 benthecarman

Btw, we should also look into allowing acting on any of these fields soon, see https://github.com/lightningdevkit/rust-lightning/issues/2914

tnull avatar Apr 25 '24 08:04 tnull