microx

microx copied to clipboard

These should be recorded as a `dev` extra in `setup.py`, instead of being hardcoded in random places.

woodruffw

DF not handled properly

1

`DF` is not having a correct value after executing some instruction. Best seen with `popf` and can crash program in other cases (by possibly not restoring properly?)

lkorenc

For example `BTS` does not work with greater immediates.

lkorenc

`pop rsp` currently returns result increased by `8` opposed to expected value. One possible explanation is that following happens: ``` new = *rsp store(dst, new) *rsp = *rsp + 8...

lkorenc

`pdoc` works well for us on other projects, we should use it here.

woodruffw

...and check them with `mypy`.

woodruffw

Saving/restoring XMM / YMM register state in inline assembly

2

I don't recall if we're actually saving/restoring enough. I think we're only saving xmm0 through xmm7. I'd need to think more about whether more is needed. I don't believe that...

pgoodman

All of our PyPI-packaged projects should use trusted publishing, rather than a manually configured API token. Example trusted publishing workflow: https://github.com/trailofbits/blight/blob/master/.github/workflows/release.yml Resources: * https://docs.pypi.org/trusted-publishers/ * https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

woodruffw