clay icon indicating copy to clipboard operation
clay copied to clipboard

Responsive behavior for Clay Tabs and Navbar

Open drakonux opened this issue 4 years ago • 5 comments
trafficstars

What is your proposal?

Due to a request from team-commerce, we would like to add responsive behavior for the navigation bar and the tabs component.

See LEXI-1035

Frame 1

Why would adopting this proposal be beneficial?

It would solve issues on small devices and other problems related to narrow spaces such as modals, side panels, etc.

What are the alternatives to this proposal?

As we defined in the document. Our desired option to manage the tabs overflow is using more + caret-down for the last tab but it would be valid also a tab with the ellipsis icon (as we did for CK Editor for example).

drakonux avatar Jan 22 '21 13:01 drakonux

Could be this behavior applied to other components like navbars, etc?

marcoscv-work avatar Jan 22 '21 14:01 marcoscv-work

Hey, @marcoscv-work I've already requested it for navbars on this request ;)

...responsive behavior for the navigation bar and the tabs component.

But in general yes, this proposal fits for any component with a horizontal/vertical stacking behavior such as toolbars (management toolbar, vertical bar, upper toolbar), tabs, etc.

drakonux avatar Jan 25 '21 07:01 drakonux

Just revisiting some old open issues!! @drakonux this is probably more related to the components, right? if I'm not mistaken we already have it ready for CSS but at the time we didn't add component support but anyway I will add the label for the components to make this more visible.

matuzalemsteles avatar Apr 20 '21 14:04 matuzalemsteles

I've had a look into this and as far as I can tell, in order to achieve this behavior, we need to change both the CSS and the JavaScript for these components. I can't see how it is possible without introducing breaking changes, which is something we want to avoid at all costs.

I also had a very quick call with @matuzalemsteles on Slack to talk about this and he mentioned the possibility of introducing "feature flags" (at least that's how I understood it) to make these existing components work in a more "responsive" way. While I think the idea is interesting, I'm a bit scared of the complexity this would introduce. Maybe creating new components would be safer and less complex.

So for the moment, I've removed my assignment from this task, and I'll let Matu take the lead.

julien avatar May 27 '21 10:05 julien

LPS Ticket https://liferay.atlassian.net/browse/LPS-190544

matuzalemsteles avatar Jul 13 '23 23:07 matuzalemsteles