SDL icon indicating copy to clipboard operation
SDL copied to clipboard

SDL3 CI/CD for Apple platforms is missing minimum OS version settings

Open kiddkaffeine opened this issue 1 year ago • 4 comments
trafficstars

The CI/CD actions for SDL3 on Apple platforms are compiled against the newest macOS/iOS/tvOS version, meaning it will:

  • miss errors that result from unchecked API usage beyond the minimum required versions and
  • cause issues for downstream users of CI/CD artifacts

I believe this can be rectified by passing an extra CMake parameter -DCMAKE_OSX_DEPLOYMENT_TARGET=11.0 (or whatever the appropriate iOS, macOS, or tvOS version.)

kiddkaffeine avatar Oct 25 '24 20:10 kiddkaffeine

From the xcode project, I have:

IPHONEOS_DEPLOYMENT_TARGET = 9.0;
MACOSX_DEPLOYMENT_TARGET = 10.11;
TVOS_DEPLOYMENT_TARGET = 9.0;
XROS_DEPLOYMENT_TARGET = 1.0;

Are those the minimum versions required for each platform?

madebr avatar Oct 25 '24 20:10 madebr

That I'm not certain about -- I asked in discord and some folks working on SDL_GPU said 11.0 -- but I think the flag needs to be set in CMake or when calling it.

kiddkaffeine avatar Oct 25 '24 21:10 kiddkaffeine

Based on https://github.com/libsdl-org/SDL/issues/11333 it looks like SDL_GPU needs iOS/tvOS 13.0 or above. Any earlier than that and we have to query support for support queries ('supportsFamily:' is only available on iOS 13.0 or newer) which seems pretty silly.

TheSpydog avatar Oct 25 '24 22:10 TheSpydog

All current API availability issues have now been addressed, so this should be all that's left.

kiddkaffeine avatar Oct 30 '24 03:10 kiddkaffeine