mupen64plus-libretro-nx icon indicating copy to clipboard operation
mupen64plus-libretro-nx copied to clipboard

Fix for SW Ep1 Racer audio with other core timings.

Open mountnside opened this issue 4 years ago • 2 comments

The "special" interrupt is used as a major timing hack.

This fix removes that hack. It also has the side effect of fixing SW Ep1 audio in other counter factors than 1. It may have other effects in other games, which haven't been tested yet.

The DK64 vine problem (and many others) will require a much more thorough looking through. The interrupt system still seems to be a complete riddle to me in how it does things.

mountnside avatar Mar 06 '21 19:03 mountnside

https://github.com/mupen64plus/mupen64plus-core/pull/708 https://github.com/mupen64plus/mupen64plus-core/pull/701#issuecomment-586724230 To give you some background. I will check back with that on Gillou

m4xw avatar Mar 06 '21 20:03 m4xw

Ideally then it would wrap to complete 2^32 I guess (or even could ditch the x86 recomp to allow for more register allocation for proper COUNT timing.)

I intend though to work on the Perfect Dark audio timing also. I am cleaning up that old patch I did.

Thanks for those notes. It does help a bit in understanding how the basic systems of Mupen works. I really got to dig into the dynarec, too.

mountnside avatar Mar 06 '21 21:03 mountnside

Whats the status quo?

m4xw avatar Sep 02 '22 11:09 m4xw

I honestly would rather I forget I ever did any work on this, let alone anything publically to begin with.

That's quite honestly the status quo.

pet-sematary

mudlord avatar Sep 08 '22 21:09 mudlord