beetle-pce-fast-libretro icon indicating copy to clipboard operation
beetle-pce-fast-libretro copied to clipboard

Published 20 hours ago • verified publisher icon libretro

Update libchdr to latest upstream.

Open negativeExponent opened this issue 1 year ago • 4 comments

Fix https://github.com/libretro/beetle-pce-fast-libretro/issues/226

negativeExponent avatar Aug 09 '24 00:08 negativeExponent

hey man, thanks for the libchdr update PRs! They are much appreciated.

Just so it's not a surprise, though: we probably won't be able to merge them for a while, as we basically have to update the libchdr in all of the cores and RetroArch all at once to avoid breaking the statically linked platforms (i.e., where the versions have to match).

So, if it's okay, just leave this PR open for a bit and we'll work toward getting everything ready for a big merge-blitz.

hizzlekizzle avatar Aug 09 '24 03:08 hizzlekizzle

If it can be updated to a git subtree instead of a submodule there'd be an easier path to getting this merged

LibretroAdmin avatar Aug 09 '24 03:08 LibretroAdmin

@hizzlekizzle @LibretroAdmin

I've sent a forced-push and replaced everything before with a subtree variant. For now im pushing it for PCE_FAST. Once its confirmed to be acceptable and ok, then ill forced-push the same things to Supergfax and Pce accuracy. then you can can check for compatibility issue with other platforms since i can do only linux and some windows (just for compiling)

negativeExponent avatar Aug 09 '24 04:08 negativeExponent

OK just to let you know I haven't forgotten about this, sorry about the time but I will get to this.

LibretroAdmin avatar Nov 08 '24 14:11 LibretroAdmin

OK just to let you know I haven't forgotten about this, sorry about the time but I will get to this.

its has been too long now. there are now two similar PRs for the same purpose just in this repo alone.

@LibretroAdmin

negativeExponent avatar Mar 28 '25 22:03 negativeExponent

hi @negativeExponent , @sonninnos has been given merge access on these repos and he has been merging libchdr update PRs for the other repos now as well. I've asked him to look into this one as well. He will either rebase this PR and merge it or come up with his own PR. Important part is though that one way or another libchdr will finally get updated. Sorry for the long wait

LibretroAdmin avatar Jun 25 '25 11:06 LibretroAdmin

Alright, looks like he made his own PR (https://github.com/libretro/beetle-pce-fast-libretro/pull/234) already some days ago, merged that and updated it. Anyway hopefully everyone is satisfied now with the outcome.

LibretroAdmin avatar Jun 25 '25 12:06 LibretroAdmin