Simplified Parameter Parsing to have all all shader formats use the same slang method

[HyperspaceMadness]

Cleanup/Simplification of shader parameter resolution process

Originally if the parameter resolution was a different code path if it was a slang shader or not even though the parameter resolution was actually supposed to be the same.

This PR removes one of the two paths so that the same parameter resolution is used for both.

Tested with both slang and glsl shaders

Reviewers

@hizzlekizzle

[hizzlekizzle]

ah, so it was meant to be removed at some point anyway, it seems, and was just kept around until someone could test it properly?

[HyperspaceMadness]

Yeah that's right, the expectation seems to be to remove it after it was tested.

In looking at the newer code it is more robust with checking if there are multiple parameters but with different values and flagging this.

[hizzlekizzle]

hmm, looks like a bunch of CI builds failed, presumably because they tried to take the now-removed codepath.

[LibretroAdmin]

Yes the CI fails need to be addressed by the author.

[LibretroAdmin]

The problem with this PR is that it will fail if HAVE_SLANG and HAVE_SPIRV_CROSS are not defined.

That's why the CI jobs are failing rn.

[HyperspaceMadness]

Ah, I see the problem, I'll see if I can move the function over which would avoid duplication of code or the need for the HAS defines.

[LibretroAdmin]

Hi @HyperspaceMadness ,

let me know if this commit replaces your PR and works as intended. Then we can close this PR.

https://github.com/libretro/RetroArch/commit/d60d320e76a58fba0870d653f21719a18ebbd13e

[HyperspaceMadness]

Yes, I think this is ok.