RetroArch icon indicating copy to clipboard operation
RetroArch copied to clipboard

[UWP] Shaders slang dont works in 1.19

Open ErivandoBR opened this issue 1 year ago • 16 comments

I can't activate shaders slang in Retroarch 1.19 In previous versions 1.17 and 1.18, slang works.

In 1.19, I can only enable shaders if I change the driver to GL. With this driver, I can activate glsl shaders.

  • RetroArch UWP 1.19 / Mesa And Angle
  • Xbox Series S dev mode

ErivandoBR avatar Jun 01 '24 21:06 ErivandoBR

Can you post a log of it failing to load a slang shader?

hizzlekizzle avatar Jun 02 '24 20:06 hizzlekizzle

Can you post a log of it failing to load a slang shader?

I tried to generate, but the log file is always blank.

I tried with RA 1.16 and RA 1.17 and log generation works normally. With RA 1.18 Mesa, I was unable to generate the log in any of the 3 Mesa/Angle versions I tried. It could be another problem in version >1.18 UWP.

ErivandoBR avatar Jun 04 '24 17:06 ErivandoBR

Same issue here after the update from 1.17. Error message failed to load shader on the regular d11/d12 driver with every preset..

Xbox series S. Alsof setting it to 4k still resolves in a black screen after loading a core.

eMSX avatar Jun 06 '24 22:06 eMSX

Same issue here. Slang shaders were working and then just stopped. Now only glsl shaders work. Running on iOS.

f0rmwk avatar Jun 12 '24 03:06 f0rmwk

Same issue here, just decided to update from 1.17 and now no slang shaders work, every one fails to load. Any update on this?

stholt5233 avatar Jun 14 '24 14:06 stholt5233

Yes. facing same issue. and logs also not working. Hope someone fix this issue. https://www.reddit.com/r/RetroArch/comments/1dikh3l/applying_preset_shader_always_failed_on_xbox_any/

Dark-Cod3r avatar Jun 18 '24 16:06 Dark-Cod3r

Is there any update on this? I'm holding off on updating until it's fixed.

Not sure if it's a Xbox or retroarch issue. Can anyone shed some light on that?

joepogo avatar Aug 14 '24 04:08 joepogo

Which build are you guys using? From retroarch.com or from xbox dev store?

hizzlekizzle avatar Aug 14 '24 18:08 hizzlekizzle

I used previous github build. Still haven't heard anything from anyone about a possible fix. Luckily the update to 1.19 is nothing major.

stholt5233 avatar Aug 14 '24 18:08 stholt5233

@hizzlekizzle I tried both versions as a test and both are broken shader wise.

I doubt it would be anything shader wise but possibly something more that changed on the retroarch video side code-wise? Since glsl works.

Hopefully they'll fix it soon. Shaders are a huge part of the experience for a lot of us.

Hopefully they'll sort the shader issue when using flycast as well.

joepogo avatar Aug 15 '24 01:08 joepogo

Just reporting iupdated to the latest version and shaders are still broken.

I'm currently looking back through commits prior to 1.19. Does anyone know if there were any major changes to the video code for retroarch before then?

It's obviously not a single shader here or there, it's all of them. I'm wondering if this issue is reproducible through dx11 or 12 on PC, though I think it'd probably would have been reported by now.

joepogo avatar Sep 26 '24 01:09 joepogo

Correct, it's not reproducible on Windows. I don't know of any major changes, no. The lack of logging makes it basically impossible to debug, as well :/

hizzlekizzle avatar Sep 26 '24 13:09 hizzlekizzle

Right Here: https://buildbot.libretro.com/stable/1.17.0/windows-msvc2019-uwp/x64/

EGCdigital avatar Dec 16 '24 20:12 EGCdigital

Is it possible that the implementation of mesa over angle broke something?

I don't know how that's possible though because the initial test builds of mesa on Xbox retroarch had working slang shaders.

I have a build with mesa working just fine and no slang shaders being broke.

joepogo avatar Dec 18 '24 17:12 joepogo

I am still waiting to see if it gets fixed in an update, but it doesn't seem like anyone involved cares. This has been broken for 9 months

stholt5233 avatar Dec 18 '24 17:12 stholt5233

It's not that no one cares, we just don't have any means to do anything about it. Most of the people who could have moved on to other things, it seems, and we're basically left holding the bag.

We don't even know anything about the Mesa integration.

EDIT: can anyone at least identify the commit where it broke? That's the first step to fixing it.

hizzlekizzle avatar Dec 18 '24 17:12 hizzlekizzle

I see that there is still no solution, it happens to me with the versions given by Git as well as the official RetroArch page, is there any old version where it still works?

Cracklitrox avatar Jan 05 '25 02:01 Cracklitrox

Get a developer in contact with us that can finally untangle this mess.

Either that or we revert everything to do with the Mesa PR since it seems that is the culprit behind all these issues, right?

LibretroAdmin avatar Jan 05 '25 06:01 LibretroAdmin

Get a developer in contact with us that can finally untangle this mess.

Either that or we revert everything to do with the Mesa PR since it seems that is the culprit behind all these issues, right?

What's so strange is that we have mesa beta builds on Xbox where the slang shaders *DO work.

Something got borked after that with implementation most likely. Hopefully a fix can be made to allow for mesa instead of angle on Xbox retroarch with slang shaders.

joepogo avatar Jan 05 '25 19:01 joepogo

yeah, I'm not totally sure it's a mesa problem, but we'll never know unless someone can build and bisect.

hizzlekizzle avatar Jan 05 '25 21:01 hizzlekizzle

Enabling HAVE_HLSL in the preproc options fixed shaders for me. Here's some experimental vulkan stuff too: https://github.com/worleydl/RetroArch/tree/uwp-updates.

edit: Hrm still having issues with slang on d3d I'll see if I can figure out anything today. edit2: Strangely d3d shaders were working in debug so I do a clean build of everything and it seems they work in Release now too. There may still be some ghosts to track down.

worleydl avatar Jan 19 '25 13:01 worleydl

Hi @worleydl,

Thanks so much for fixing this issue! So going forward slang shaders are back to being fixed on mesa and angle builds on Xbox series consoles, correct?

I just had a couple of questions,I noticed on your GitHub repro you reference vulkan on some of your commits, are you looking at attempting to getting vulkan working on Xbox series consoles or am I reading it wrong? :p

One other thing, There's been a long standing issue trying to get threading to work on retroarch mame on series consoles, it was causing crashing before loading on discrete sound core and other games.

A fix was made to deactivate the threading because of this, but a good number of chd games and other higher end mame games are now not full speed because the threading really helps.

Is it possible to fix that, it's discussed here with links and a possible fix but it's way over my pay grade. It would be awesome to get threading working and those games back to full speed. Is it possible to get you to take a look at it?

See here:

https://github.com/libretro/mame/issues/326

Regardless, thank you for all you have done. It's difficult to find devs that are willing to fix Xbox related issues. But the good news is that that list is getting shorter!

joepogo avatar Jan 22 '25 17:01 joepogo

So going forward slang shaders are back to being fixed on mesa and angle builds on Xbox series consoles, correct?

Yes

are you looking at attempting to getting vulkan working on Xbox series consoles

It's "working" via vulkan_dzn which is a limited wrapper over D3D12. I did experiment with it on ra but I have no plans to push as it currently serves no purpose but to add confusion. Stability fixes for D3D12 will be coming soon. dzn may have other applications for basic vulkan renderers, a lot of low level compute is not available on xbox, so it's neat but not very capable.

Is it possible to get you to take a look at it?

No, that doesn't seem like something I have any ideas for at the moment.

worleydl avatar Jan 22 '25 23:01 worleydl

Thank you nonetheless @worleydl for fixing this!

I'll keep an eye out for the next retroarch mess build with fixed shaders.

Regarding the mesa builds, are all the kinks ironed out or is it still a beta?

I think the build I have is currently the first mesa build the discord had for download.

Regardless, thank you for your time and answering my questions. 👍😊

joepogo avatar Jan 23 '25 18:01 joepogo

Seems like some work is getting done...but I just checked stable and nightlies on the website...nothing there, 404 Not Found...Does anyone have a link to the UWP release for Xbox series X?

stholt5233 avatar Jan 24 '25 03:01 stholt5233

I haven't yet found time to test it but it should be available on the follow-up page,:

https://github.com/EmulationCollective/RetroArch/releases/tag/latest

eMSX avatar Jan 24 '25 06:01 eMSX

Thanks for that!

On Fri 24 Jan 2025, 06:09 eMSX, @.***> wrote:

I haven't yet found time to test it but it should be available on the follow-up page,:

https://github.com/EmulationCollective/RetroArch/releases/tag/latest

— Reply to this email directly, view it on GitHub https://github.com/libretro/RetroArch/issues/16634#issuecomment-2611678481, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJMJCJIJ2BVN7TBNCMTKB32MHKKFAVCNFSM6AAAAABIUPHFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGY3TQNBYGE . You are receiving this because you commented.Message ID: @.***>

stholt5233 avatar Jan 24 '25 11:01 stholt5233

Enabling HAVE_HLSL in the preproc options fixed shaders for me. Here's some experimental vulkan stuff too: https://github.com/worleydl/RetroArch/tree/uwp-updates.

edit: Hrm still having issues with slang on d3d I'll see if I can figure out anything today. edit2: Strangely d3d shaders were working in debug so I do a clean build of everything and it seems they work in Release now too. There may still be some ghosts to track down.

@worleydl Hi sir! Im expecting the same trouble listed above, my question is...

How can i apply this correction? To my installed XSX app? Do i need to redownload and reinstall it?

Thanks in advance, have a good day.

DevSergioSiller avatar Feb 16 '25 09:02 DevSergioSiller

I haven't yet found time to test it but it should be available on the follow-up page,:

https://github.com/EmulationCollective/RetroArch/releases/tag/latest

Is there anywhere else to find this updated mesa build? That link is broken. :/

joepogo avatar Feb 16 '25 12:02 joepogo

@DevSergioSiller @joepogo I don't think an official UWP build has been pushed up yet but the EmulationCollective latest does have the patch. I think they restructured how builds go out so you just have to find the last rolling release instead of the "latest" tag.

I also believe this issue to be resolved now, the previous "ghosts" mentioned were due to stale build configs hanging around.

worleydl avatar Feb 16 '25 13:02 worleydl