RetroArch icon indicating copy to clipboard operation
RetroArch copied to clipboard

Incorporate FreeBSD port patches

Open ehaupt opened this issue 1 year ago • 5 comments

Description

This commit integrates a series of patches from the FreeBSD port, enhancing build compatibility and resolving specific FreeBSD-related issues. They tackle a variety of issues, including compiler warnings and system-specific dependencies.

Related Issues

  • No specific issues in the upstream repository are directly addressed by this pull request. However, it aims to preemptively solve potential build and compatibility problems for FreeBSD users.

Related Pull Requests

  • None. This is a standalone pull request, requiring no dependent changes from related repositories.

ehaupt avatar Feb 10 '24 21:02 ehaupt

Can you fix the failed CI build error?

LibretroAdmin avatar Feb 12 '24 13:02 LibretroAdmin

Apparently, the FreeBSD macro is also activated for the ORBIS builds, which I did not anticipate. I'll try a few things and will squash the commits if the pipeline reports success.

ehaupt avatar Feb 18 '24 07:02 ehaupt

I've fixed the PS4/ORBIS CI build and squashed all the commits.

Is there any chance we could get a FreeBSD amd64 CI runner?

ehaupt avatar Feb 18 '24 08:02 ehaupt

Is there any chance we could get a FreeBSD amd64 CI runner?

We will need to add Cirrus CI or Travis CI ?

We have Travis but it will need some update to make it work again (was used for coverity scan IIRC).

gouchi avatar Feb 19 '24 14:02 gouchi

We will need to add Cirrus CI or Travis CI ?

We have Travis but it will need some update to make it work again (was used for coverity scan IIRC).

I'd go with Travis if you already got it. But there is no hurry. It would be nice to have.

ehaupt avatar Feb 19 '24 16:02 ehaupt

Hi @gouchi, I was wondering if we might have an opportunity to merge this while it's conflict-free? Also, if you think it would be helpful, I'm more than willing to open a separate issue to discuss the pipeline in more detail. Please let me know your thoughts or if there's anything else I can do to assist. Thanks so much for your time and efforts!

ehaupt avatar Mar 22 '24 16:03 ehaupt

@ehaupt Sure we can discuss the pipeline in more detail to a separate issue to enable FreeBSD CI test.

@LibretroAdmin CI build error has been fixed.

gouchi avatar Mar 23 '24 17:03 gouchi

I tested on FreeBSD 14.1 and I confirm that the patches are needed to compile RA.

git clone https://github.com/libretro/RetroArch.git
cd RetroArch
git fetch origin pull/16221/head:pr16221
git checkout pr16221
./configure && gmake -j$(nproc)

If needed configure and gmake ouput.

Without it you got this error.

@LibretroAdmin This PR should be good to be merged. Thank you.

P.S = I had to disable Discord otherwise you got linking issue but it is not related to this PR and it is also disable on FreeBSD.

gouchi avatar Jul 30 '24 12:07 gouchi

Any chance this could be merged?

ehaupt avatar Jul 30 '24 20:07 ehaupt