RetroArch
RetroArch copied to clipboard
[draft] / [don't merge] Add support for scale_to = original in slang …
…presets for vulkan and glcore drivers
Description
Retroarch supports source,viewport,absolute in shader presets, now it supports "original" too, which is handy for shader writers if they want to return to original dimensions after using anything but "source" in the previous passes.
Reviewers
@Hunterk suggested me to open this as a draft, since i was unable to implement the feature for remaining output drivers.
@HyperspaceMadness I know you've been interested in this capability for some time.
Looks really good, we just need to get the other drivers covered then we're golden!
@kokoko3k you may want to adjust your commit to keep all the original formatting except in the areas you changed code in,it will make this easier to review
Looks really good, we just need to get the other drivers covered then we're golden!
@kokoko3k you may want to adjust your commit to keep all the original formatting except in the areas you changed code in,it will make this easier to review
I've messed it a bit, btw, the readable commit is this ^_^ 2e8bd62ae597439e97dd9e1158ed357846bd8adf
OK, so the only error that precludes all tests from passing is this -
gfx/drivers/gl2.c:1818:15: error: enumeration value 'RARCH_SCALE_ORIGINAL' not handled in switch [-Werror,-Wswitch] switch (fbo_scale->type_x) ^~~~~~~~~~~~~~~~~ gfx/drivers/gl2.c:1842:15: error: enumeration value 'RARCH_SCALE_ORIGINAL' not handled in switch [-Werror,-Wswitch] switch (fbo_scale->type_y) ^~~~~~~~~~~~~~~~~
If this can be addressed, we can proceed with this PR.
Can this PR be merged at this point?
@LibretroAdmin it's only for glcore and vulkan currently (i.e., no d3d*). If that's okay, then it's probably fine.
lol looks like librashader already merged "original" scale. We gotta keep up! :P