RetroArch icon indicating copy to clipboard operation
RetroArch copied to clipboard

Adding localization support to cheevos.c

Open toadkarter opened this issue 2 years ago • 2 comments

Description

There were some TODOs surrounding unlocalized strings in cheevos.c, so I have added localization support to these in the same style as the rest of the project (i.e., added the relevant info to msg_hash and msg_hash_us.

Hopefully this is in line with what is expected, but if not please do let me know and I would be happy to make any changes.

Related Issues

N/A

Related Pull Requests

N/A

Reviewers

N/A

toadkarter avatar Sep 25 '23 22:09 toadkarter

@Jamiras Thank you for your helpful comments - I will make changes in a new commit just so that they are easier to review, and then if these are ok from your perspective I will squash these commits for readability in the main build

toadkarter avatar Sep 26 '23 07:09 toadkarter

Hi, just a couple of code style nits, single line code blocks don't need a bracket.

LibretroAdmin avatar Sep 26 '23 12:09 LibretroAdmin