RetroArch icon indicating copy to clipboard operation
RetroArch copied to clipboard

Published 20 hours ago • verified publisher icon libretro

System Information not correctly detecting Windows 11

Open ichee opened this issue 4 years ago • 8 comments

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

Retroarch System Information incorrectly detecting Windows 11 as Windows 8.

Expected behavior

Correct OS and Build detected

Actual behavior

Shows Windows 8 instead

Steps to reproduce the bug

  1. Start Retroarch
  2. Navigate to Information
  3. Navigate to System Information
  4. Observe wrong OS under Frontend OS

Bisect Results

Changelog for Stable 1.9.11 listed as fixed, but it is not.

Version/Commit

Stable 1.9.11

Also tested with latest nightly build ac1a280

Environment information

Windows 11 Pro

cap

ichee avatar Oct 13 '21 09:10 ichee

This issue should have been addressed by this commit but it seems it is not yet settled according to those threads.

gouchi avatar Oct 13 '21 12:10 gouchi

Stable build 1.8.9, 4c6b13919c, is reported more correctly (at least the build number is correct).

It also detects Windows 10 instead of Windows 8, still wrong OS but closer.

cap2

ichee avatar Oct 14 '21 03:10 ichee

Windows 10 is also incorrectly detected as Windows 8 as well.

Manual builds from master using mingw64 seems to correctly detect the OS, so it appears to be a buildbot problem.

cap3

ichee avatar Oct 14 '21 04:10 ichee

Detects it fine here -

image

image

inactive123 avatar Oct 20 '21 13:10 inactive123

Same issue still present, as well as on system running Windows 10.

Build 758eafa.

Buildbot:

buildbot

Manual build:

manual_build

ichee avatar Oct 21 '21 06:10 ichee

https://github.com/libretro/RetroArch/blob/763fcd8267d14af6ef39423b1412eab6f273c6c8/frontend/drivers/platform_win32.c#L292

It seems like GetVersionEx has been deprecated for Win10+:

[GetVersionEx may be altered or unavailable for releases after Windows 8.1. Instead, use the Version Helper functions]

Applications not manifested for Windows 8.1 or Windows 10 will return the Windows 8 OS version value (6.2).

The replacement helper functions appear to be designed to detect a supported version, not to report the current version. I'm not sure what the recommended solution is.

Jamiras avatar Feb 04 '22 20:02 Jamiras

We might try to make some test with RtlGetVersion ? But it is only available from Windows 2000.

Source

gouchi avatar Feb 05 '22 18:02 gouchi

Can confirm this happens on Windows 11 Pro (21H2). Windows 11 Home (21H2) is fine tho.

LibretroAdmin avatar Oct 03 '22 14:10 LibretroAdmin

This issue still persists. My 64-bit Windows 10 Home 22H2 is being detected as Windows 8 x64 Build 9200 (v6.2).

ZucriyAmsuna avatar Dec 09 '23 18:12 ZucriyAmsuna