test-plans icon indicating copy to clipboard operation
test-plans copied to clipboard

docs: include required chunk size in perf readme

Open achingbrain opened this issue 2 years ago • 2 comments

I almost changed the default to something bigger because it improves the benchmark results..

It's probably worth stating explicitly what the chunk size is so every implementation uses the same value for consistency.

achingbrain avatar Nov 07 '23 10:11 achingbrain

because it improves the benchmark results..

Great. Then I suggest increasing it in js-libp2p. That said, worth investigating why js-libp2p is CPU bottlenecked on the chunk size?

mxinden avatar Nov 08 '23 14:11 mxinden

Then I suggest increasing it in js-libp2p

The point of this PR is so that all implementations use the same chunk size so there is a better basis for comparison. Is this not something we want?

achingbrain avatar Nov 08 '23 16:11 achingbrain