rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

chore(deps): bump hickory-resolver and hickory-proto

Open hanabi1224 opened this issue 8 months ago • 4 comments

Description

Notes & open questions

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

hanabi1224 avatar Apr 01 '25 05:04 hanabi1224

@jxs since async-std-resolver has not published a v0.25 stable version, thus it's incompatible with [email protected] I have to revert to v0.24 to make it compile. We could do the upgrade again once either async-std is removed from rust-libp2p or async-std-resolver publishes a v0.25 stable version.

hanabi1224 avatar Apr 03 '25 11:04 hanabi1224

I would prefer if we not downgrade the version back to v0.24. Is the current dependency to the unstable 0.25.0-alpha an issue for you @hanabi1224? Otherwise I'd suggest we wait for the async-std-resolver stable release.

elenaf9 avatar Apr 05 '25 23:04 elenaf9

@elenaf9 Unfortunately async-std-resolver has been deprecated and v0.25 will not likely be released. If downgrade is not desired, this could only be landed after async-std code is removed from rust-libp2p

https://github.com/hickory-dns/hickory-dns/releases/tag/v0.25.0

Support for the async-std runtime has been removed following the deprecation of the async-std crate by upstream (see their README). The async-std-resolver crate will no longer be updated.

hanabi1224 avatar Apr 07 '25 13:04 hanabi1224

@elenaf9 Unfortunately async-std-resolver has been deprecated and v0.25 will not likely be released. If downgrade is not desired, this could only be landed after asyn-std code is removed from rust-libp2p

https://github.com/hickory-dns/hickory-dns/releases/tag/v0.25.0

Support for the async-std runtime has been removed following the deprecation of the async-std crate by upstream (see their README). The async-std-resolver crate will no longer be updated.

We agreed now to remove async_std support, so once that's done we can move forward with the PR.

elenaf9 avatar Apr 07 '25 23:04 elenaf9

#5959 will be merged soon, then we can continue here. Sorry for the delay @hanabi1224.

elenaf9 avatar Jun 24 '25 07:06 elenaf9

This pull request has merge conflicts. Could you please resolve them @hanabi1224? 🙏

mergify[bot] avatar Jun 24 '25 18:06 mergify[bot]