rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

identify protocol could close connection if remote peer sends invalid public key

Open jameshiew opened this issue 11 months ago • 8 comments

Description

Remote peer shouldn't ever be providing a public key that doesn't match their peer ID, in this case could close the connection

I haven't tested but it looks like this is what js-libp2p does, for example (https://github.com/libp2p/js-libp2p/blob/d19974d93a1015acfca95c2155dbcffc5fd6a6c0/packages/protocol-identify/src/identify.ts#L106-L108)

Motivation

See discussion at * https://github.com/libp2p/rust-libp2p/pull/5707#discussion_r1866001556

Current Implementation

identify protocol connection to remote peer stays open

Are you planning to do it yourself in a pull request ?

Maybe

jameshiew avatar Dec 04 '24 17:12 jameshiew