js-libp2p icon indicating copy to clipboard operation
js-libp2p copied to clipboard

[Meta] Crypto updates

Open jacobheun opened this issue 5 years ago • 4 comments

This is a meta issue to track work I will be doing around various crypto updates in libp2p.

Noise

We are planning on deprecating libp2p-secio in favor of libp2p-noise. ETA's are based on current estimated timelines of IPFS version updates and are subject to change.

  • [x] js-libp2p uses libp2p-noise in all tests
  • [x] js-libp2p uses libp2p-noise in all examples
  • [x] Integrate libp2p-noise into js-ipfs as fallback for libp2p-secio (ETA: June 23rd)
    • [ ] Remove support for libp2p-secio in js-ipfs (ETA: Aug 11th)

ed25519 Keys (ETA: [email protected])

  • [ ] js-libp2p defaults to ed25519 keys in all tests
  • [x] libp2p/interop tests are being done on ed25519 keys
  • [x] ipfs/interop tests are being done on ed25519 keys
  • [x] ed25519 keys in libp2p-crypto match the API of rsa keys (they currently differ)
    • [x] Shoud fix https://github.com/ipfs/js-ipfs/issues/2553

Big Fixes

  • [ ] Resolve MAC Invalid error
  • [x] Interop ed25519 key marshaling https://github.com/libp2p/js-libp2p-crypto/issues/175

jacobheun avatar Apr 24 '20 14:04 jacobheun

cc @achingbrain @hugomrdias @vasco-santos

jacobheun avatar Apr 24 '20 14:04 jacobheun

@jacobheun we should default PeerId.create to use ed25519 keys as well. When would be a good time for that in this timeline?

vasco-santos avatar Jun 08 '20 16:06 vasco-santos

@jacobheun we should default PeerId.create to use ed25519 keys as well. When would be a good time for that in this timeline?

@vasco-santos we could time a breaking change of PeerId with the 0.29 work so that we time that with signed peer records.

jacobheun avatar Jun 08 '20 16:06 jacobheun

The major outstanding issue left for this is Keychain support for ed25519 keys, which is due to a lack of import/export support in js-libp2p-crypto.

jacobheun avatar Jul 20 '20 15:07 jacobheun

I believe all outstanding items have been implemented. Feel free to reopen if not the case

wemeetagain avatar Sep 28 '23 02:09 wemeetagain