js-libp2p icon indicating copy to clipboard operation
js-libp2p copied to clipboard

chore: use %e token anywhere we are logging errors with @libp2p/logger

Open SuchitraSwain opened this issue 6 months ago • 1 comments

Title

Description

Notes & open questions

Change checklist

  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • [ ] I have added tests that prove my fix is effective or that my feature works

SuchitraSwain avatar Jun 04 '25 10:06 SuchitraSwain

@SuchitraSwain thanks for the PR - for next steps. Please address the review comments left here

p-shahi avatar Jun 10 '25 15:06 p-shahi

@achingbrain @SgtPooki could you please approve this PR

SuchitraSwain avatar Jun 23 '25 08:06 SuchitraSwain

@SuchitraSwain there is still an unrelated formatting change here, see the unresolved comment.

There are also still many instances of passing errors to a logger that have not had the %e token added to them left in the codebase so this PR does not completely address the issue yet.

achingbrain avatar Jul 07 '25 05:07 achingbrain

Checking out again, will address all the error instance

SuchitraSwain avatar Jul 07 '25 09:07 SuchitraSwain

Thanks for opening this PR. I'm closing it due to lack of activity in the last two months and because #3261 has been opened which adds the %e token to the necessary locations as requested here.

achingbrain avatar Sep 05 '25 08:09 achingbrain