js-libp2p icon indicating copy to clipboard operation
js-libp2p copied to clipboard

interop: add electron transport interop ping test

Open p-shahi opened this issue 2 years ago • 3 comments

node.js/electron support for webrtc transport was added in https://github.com/libp2p/js-libp2p/pull/1905 & supports:

  • Dialing private-to-private
  • Listening private-to-private
  • Dialing private-to-public

Currently blocked on the fact that all WebRTC tests are disabled: https://github.com/libp2p/js-libp2p/issues/1846

p-shahi avatar Aug 07 '23 23:08 p-shahi

This is unblocked now. WebRTC/WebRTC Direct tests are run against node.js already but not electron.

Electron should run the same suite of transport tests as node.js.

To implement this:

  1. Create an ElectronDockerfile similar to https://github.com/libp2p/js-libp2p/blob/main/interop/BrowserDockerfile
  2. Build the electron container in https://github.com/libp2p/js-libp2p/blob/main/interop/Makefile
  3. Create an electron-version.json similar to https://github.com/libp2p/js-libp2p/blob/main/interop/node-version.json
  4. Add it to extra-versions - https://github.com/libp2p/js-libp2p/blob/main/.github/workflows/main.yml#L236

achingbrain avatar Feb 25 '25 09:02 achingbrain

@achingbrain I want to work on this Issue.

sumanjeet0012 avatar Mar 05 '25 14:03 sumanjeet0012

Great, please submit a PR!

achingbrain avatar Mar 05 '25 15:03 achingbrain