js-libp2p icon indicating copy to clipboard operation
js-libp2p copied to clipboard

Configuration page needs updates

Open wemeetagain opened this issue 3 years ago • 2 comments

Issues seen while migrating lodestar to latest libp2p:

  • configuration page references peer store "persistence", no longer an option, should use PersistentPeerStore instead
  • persistent: boolean listed in an unused interface in src/index.ts
  • dialer: {...} referenced in configuration page, should instead be under connectionManager
  • ...

wemeetagain avatar May 26 '22 13:05 wemeetagain

Hand-written docs do get out of sync from time to time. Would you like to submit a PR that brings everything up to date?

achingbrain avatar Jun 24 '22 13:06 achingbrain

I have a branch in progress. waiting on a fix for https://github.com/bbc/typescript-docs-verifier/issues/22

wemeetagain avatar Sep 05 '22 16:09 wemeetagain

@wemeetagain : we're unblocked here now right?

BigLep avatar Oct 04 '22 15:10 BigLep

Yes this is unblocked. It may be useful to break this work up into separate PRs since there's a lot of changes required. I can start with doc/CONFIGURATION.md.

wemeetagain avatar Oct 06 '22 16:10 wemeetagain

@wemeetagain I have a draft PR here to introduce typescript-docs-verifier to check the configs , I'd be happy to help with updating the config docs if you could point me to the branches you had started on.

Given we will have generated docs once https://github.com/libp2p/js-libp2p/issues/1455 is closed, I don't think we would need to document some of the internal options and type descriptions.

@achingbrain do you think we should add typescript-docs-verifier as a feature to aegir in order to use it here?

maschad avatar Dec 02 '22 21:12 maschad