go-libp2p-webrtc-direct icon indicating copy to clipboard operation
go-libp2p-webrtc-direct copied to clipboard

Published 20 hours ago • verified publisher icon libp2p

switch to using the standard libp2p upgrader

Open tobowers opened this issue 6 years ago • 0 comments

I'm opening this as a draft given our discussion of #17 . I don't see how the transport would work even in go libp2p, but I didn't do any testing of go <-> go libp2p. It really doesn't work with js libp2p -> go libp2p using this as a transport.

The problem lies in this transport trying to do its own muxing... so when the "standard" options on libp2p are set, it tries to do a security update and the multistream/1.0.0 protocol and that fails when talking to this transport.

This PR switches things around to use the default libp2p upgrader.

I realize this PR probably isn't mergable as is, but I figured I'd open it up for discussion.

tobowers avatar Aug 23 '19 08:08 tobowers