git2go icon indicating copy to clipboard operation
git2go copied to clipboard

Set BasicAuth in http.go only if username and password are not empty (#914)

Open github-actions[bot] opened this issue 3 years ago • 0 comments

This prevents error "read/write on closed pipe".

Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the CredentialsCallback will attempt to read/write on a closed pipe.

(cherry picked from commit 9db5de109c166aa802b85cfae2dced3c4728a00d)

github-actions[bot] avatar Jul 13 '22 11:07 github-actions[bot]