git2go icon indicating copy to clipboard operation
git2go copied to clipboard

Pass RemoteCallbacks to Push operation

Open joseferminj opened this issue 10 years ago • 2 comments

Pass RemoteCallbacks to remote.Push operation.

Also it fixes a memory allocation problem of the PushOptions and FetchOptions structs.

joseferminj avatar Jul 18 '15 15:07 joseferminj

This contains a lot of unrelated whitespace changes which makes it harder to figure out what you did mean to change.

The change to Fetch() is not explained anywhere? Why is it necessary to move to allocate the structure in C?

carlosmn avatar Jul 24 '15 11:07 carlosmn

Hi,

Sorry for this pull request. it contains three unrelated changes:

  • Fix Format. I created a new PR to formatting the code https://github.com/libgit2/git2go/pull/229

  • Includes RemoteCallback in PushOptions: https://github.com/joseferminj/git2go/pull/1

  • Fix Fetch Allocation: https://github.com/joseferminj/git2go/pull/2

    I don't know how to create a PR that depends in another PR. So I created two PR in my own forked repo. When FixFormat is merge in 'next' I will create the other two PRs.

Thanks

joseferminj avatar Jul 24 '15 15:07 joseferminj