react-redux-meteor icon indicating copy to clipboard operation
react-redux-meteor copied to clipboard

mapTrackerToProps doesn't re-evaluates when props changed on Meteor 1.4.1

Open tempik opened this issue 9 years ago • 10 comments

If ownProps is specified as a second argument, its value will be the props passed to your component, and mapTrackerToProps will be additionally re-invoked whenever the component receives new props (e.g. if props received from a parent component have shallowly changed, and you use the ownProps argument, mapTrackerToProps is re-evaluated).

mapTrackerToProps is calling only once on component mount ( and when reactive data source changes), but not after container component props changed. I found this issue when passing params to container component from React Router, and then i tried to get it working by direct props setup from parent component by click on button, ineffectually.

tempik avatar Aug 22 '16 20:08 tempik

i'd like to note that the mapStateToProps called every time i changed props from parent component as it should works.

tempik avatar Aug 22 '16 20:08 tempik

Thanks for letting me know. I will try to fix this bug soon.

lhz516 avatar Aug 22 '16 20:08 lhz516

any news on this?

MaxTwentythree avatar Dec 28 '16 14:12 MaxTwentythree

@lhz516 , is this library actively maintained? No worries if not, just want to check because the repo is many commits behind main redux and I don't want to pick up a dependency that will go stale.

john-osullivan avatar Apr 11 '17 06:04 john-osullivan

Thanks for everyone but this repo is no longer maintained, because I'm currently using react-komposer which is great for Meteor + React.

If anyone wants to take over this project, I can transfer the ownership to you.

lhz516 avatar Apr 11 '17 06:04 lhz516

Nope, not looking to pick up any more work than I've already got! How are you using react-komposer to bridge Minimongo & Redux? That's my big issue right now. Amy helpful blog posts you could send me toward?

On Tue, Apr 11, 2017, 02:53 Hanz Luo [email protected] wrote:

Thanks for everyone, but this repo is no longer maintained, because I'm currently using react-komposer https://github.com/arunoda/react-komposer which is great for Meteor + React.

If anyone wants to take over this project, I can transfer the ownership to you.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lhz516/react-redux-meteor/issues/1#issuecomment-293168123, or mute the thread https://github.com/notifications/unsubscribe-auth/ADpNtUM-QxLEyYKiHsBjF43tOxdmNTkMks5ruyN5gaJpZM4JqQE5 .

john-osullivan avatar Apr 11 '17 06:04 john-osullivan

@john-osullivan https://github.com/arunoda/react-komposer#for-meteors-tracker

Read the complete README. Here is the usage of how react-komposer works with Redux and Tracker(which includes the reactive mini mongo)

lhz516 avatar Apr 11 '17 07:04 lhz516

@lhz516 I'll take over the project if you want.

LaughingBubba avatar Oct 01 '17 09:10 LaughingBubba

@LaughingBubba Good to know. Instead of transfering the ownership of this project, I recommend you to create your own repo.

You can implement with the latest react-redux. Once you've done, I can unpublish react-redux-meteor on NPM so that you can reuse the package name to maintain it.

lhz516 avatar Oct 19 '17 23:10 lhz516

FWIW, I found that meteor-redux-middlewares got the job done. Maybe it doesn't fit your needs, but there something to be said for coalescing this Meteor+React+Redux community around some common options.

On Thu, Oct 19, 2017, 19:36 Hanz Luo [email protected] wrote:

@LaughingBubba https://github.com/laughingbubba Good to know. Instead of transfering the ownership of this project, I recommend you to create your own repo.

You can implement with the latest react-redux. Once you've done, I can unpublish react-redux-meteor on NPM so that you can reuse the package name to maintain it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lhz516/react-redux-meteor/issues/1#issuecomment-338066640, or mute the thread https://github.com/notifications/unsubscribe-auth/ADpNtbXH5AzlVKmAis56TftyuXRyP6Dgks5st9zsgaJpZM4JqQE5 .

john-osullivan avatar Oct 19 '17 23:10 john-osullivan