activerecord-clean-db-structure icon indicating copy to clipboard operation
activerecord-clean-db-structure copied to clipboard

PRIMARY KEY only for table, FOREIGN TABLE not support it

Open ermolaev opened this issue 8 years ago • 7 comments
trafficstars

ermolaev avatar May 02 '17 22:05 ermolaev

hello @lfittl, why you not accept my pull request?

ermolaev avatar May 10 '17 12:05 ermolaev

@ermolaev Sorry, been very busy. Thanks for your contribution!

It seems that this wouldn't work if the id column was not listed first in the table - is there a way we can implement this where it allows other columns to be listed in between?

lfittl avatar May 11 '17 19:05 lfittl

Yes you are right! I fixed it.

ermolaev avatar May 11 '17 20:05 ermolaev

@ermolaev Sorry for not getting back about this - could you re-base this PR?

lfittl avatar Jun 13 '17 23:06 lfittl

@ermolaev Your changes look good, could you rebase on top of current master?

olleolleolle avatar Oct 18 '17 08:10 olleolleolle