less.js icon indicating copy to clipboard operation
less.js copied to clipboard

Comments with doubleslash are not stripped before compile

Open matthew-dean opened this issue 1 year ago • 2 comments

Discussed in https://github.com/less/less.js/discussions/4262

Originally posted by mperry2 February 29, 2024 I've got a variable that's a list of several hundred items. I'd like to add comments between blocks of the items like I would in a regular programming language. I read at https://github.com/less/less.js/issues/202#issuecomment-775536 that // comment will be removed, so I used those. However, the comments are not being stripped out before processing and are becoming part of the list.

I'm wondering if something's wrong with my syntax and I'm just not seeing it.

Here's a contrived test case. Link to Less-To-CSS Playground

less source:

@items:
// Fruit
    apple,
    banana,
    cherry,

// Vegetables
    carrot,
    potato,
;

each(@items, {
  div#@{value} {
    color: blue;
  }
})

Output:

div#apple {
  color: blue;
}
div#banana {
  color: blue;
}
div#cherry {
  color: blue;
}
div#// Vegetables carrot {
  color: blue;
}
div#potato {
  color: blue;
}

Notice that line 10 has div#// Vegetables carrot as the selector when it should be div#carrot.

Any idea on how to fix this? I don't want to use multiple lists.

matthew-dean avatar Mar 06 '24 19:03 matthew-dean

I have a fix for this issue. I will submit a PR to resolve sometime later today (11/27/24).

puckowski avatar Nov 27 '24 10:11 puckowski

Should be resolved via https://github.com/less/less.js/pull/4293 Less version 4.2.2

puckowski avatar Jan 30 '25 23:01 puckowski