less.js icon indicating copy to clipboard operation
less.js copied to clipboard

Fix #2991

Open MoonCoral opened this issue 4 years ago • 6 comments

Closes #2991

Only comments have isSilent as far as I could see. No comment should cause a parent to be printed in the 'referenced' case. Thus I'm not even sure what the condition I deleted aimed to achieve.

Test is based on the snipped posted in #2991. css-3.css contained an empty @ rule, I assume to bypass the issue raised in #2991.

MoonCoral avatar Sep 24 '21 08:09 MoonCoral

Test failure seems to be a change of formatting of an error message in node 16. I don't see any relation to my changes.

 - /home/runner/work/less.js/less.js/packages/test-data/errors/eval/javascript-error: FAIL
SyntaxError: JavaScript evaluation error: 'TypeError: Cannot read property 'toJS' of undefined' in /home/runner/work/less.js/less.js/packages/test-data/errors/eval/javascript-error.less on line 2, column 10:¶
SyntaxError: JavaScript evaluation error: 'TypeError: Cannot read properties of undefined (reading 'toJS')' in /home/runner/work/less.js/less.js/packages/test-data/errors/eval/javascript-error.less on line 2, column 10:¶
1 .scope {
2     var: `this.foo.toJS`;
3 }

MoonCoral avatar Sep 24 '21 09:09 MoonCoral

@MoonCoral Yes, it's not your issue. @matthew-dean Hi, Matthew. What't your opinion about this CI failure case ?

iChenLei avatar Sep 24 '21 09:09 iChenLei

@MoonCoral Please update your branch, upstream master branch solved the CI problem.

iChenLei avatar Oct 07 '21 02:10 iChenLei

Rebased on master

MoonCoral avatar Oct 07 '21 09:10 MoonCoral

@MoonCoral CI has been fixed, please update your work, thanks !

iChenLei avatar Nov 11 '21 06:11 iChenLei

If all other tests pass, this seems good.

matthew-dean avatar May 04 '22 14:05 matthew-dean