less-plugin-clean-css icon indicating copy to clipboard operation
less-plugin-clean-css copied to clipboard

Published 20 hours ago • verified publisher icon less

Upgrade clean css and some improvements

Open derTobsch opened this issue 2 years ago • 7 comments

  • upgrade clean-css to 5.3.2
  • use const and let instead of var
  • add .editorconfig
  • improve readme

It should still work, but please check again

❯ lessc file.less --clean-css="--s1 --advanced --compatibility=ie8"
h2{color:coral}h3{color:purple}%

derTobsch avatar Nov 28 '23 12:11 derTobsch

Hey @matthew-dean, do you need anything else from me? Is this pr ok?

derTobsch avatar Dec 05 '23 15:12 derTobsch

@derTobsch I guess this plugin has no tests? 🤔

matthew-dean avatar Dec 10 '23 18:12 matthew-dean

@derTobsch I guess this plugin has no tests? 🤔

Yep :) Not even one.

derTobsch avatar Dec 11 '23 07:12 derTobsch

@derTobsch If you feel pretty confident about this, I think we can merge it

matthew-dean avatar Dec 11 '23 19:12 matthew-dean

@derTobsch If you feel pretty confident about this, I think we can merge it

go for it. Otherwise we will fix it

derTobsch avatar Dec 18 '23 08:12 derTobsch

@matthew-dean is there anything else I can do?

derTobsch avatar Feb 02 '24 08:02 derTobsch

ping :)

derTobsch avatar Mar 06 '24 20:03 derTobsch

@matthew-dean, how does it look?

derTobsch avatar Mar 22 '24 11:03 derTobsch

Hey @matthew-dean, its me again :) I added the basic tests from #27 (#30) and also added a github workflow to run the tests. You need to enable GitHub Actions for this repo to see the results.

derTobsch avatar Apr 11 '24 13:04 derTobsch

Yeah and thanks @matthew-dean. I think we can now close #30 and #33

derTobsch avatar Apr 18 '24 08:04 derTobsch