Hsiaoming Yang comments

Results 250 comments of


                                            Hsiaoming Yang

Voice sources

Added here: https://captcha.lepture.com/audio/#voice-library

Feature request: provide a default JWT token validator

Close this issue in favor of #427. There is a standard for JWT access token now.

`OAuth2Request` object does not support list in query params

I don't know if OAuth 2.0 supports multiple scope in this way. Can you show me the RFC description? From what I know, the `scope` should be using `+`: ```...

Session cookie grows indefinitely, results in CSRF Warning.

@Wauplin A PR is welcome. Thank you.

Make sure 'code' returns None instead of crashing if key is missing.

It will not crash, Flask will raise a 400 bad request for this case, unless Flask has changed this behavior.

Add remove_client method to base_client.registry.BaseOAuth

Hi, thanks. It would be great if you can add a test case for this method.

Delete/remove client method (flask client)

I think it is a good feature, feel free to send a pull request. The method should be added in every clients.

Consider using super() to initialize httpx clients

@Lawouach @lspgn A pull request is welcome.

HTTPX: add send method

@lspgn thanks for your work. Maybe you need to add a test case for `send` method.

Starlette/FastAPI resource protector implementation

Hi, I don't quite understand the question. Currently, starlette/FastAPI has only the client integration, while you are comparing fastapi's client documentation with Flask's server documentation.