leptos icon indicating copy to clipboard operation
leptos copied to clipboard

Published 20 hours ago • verified publisher icon leptos-rs

MSRV Bump to 1.80.0, drop crate lazy_static and use std::sync::LazyLock.

Open martinfrances107 opened this issue 1 year ago • 4 comments

#2726

martinfrances107 avatar Aug 04 '24 19:08 martinfrances107

Sorry for the commit spree ... finally found the path out of the woods.

martinfrances107 avatar Aug 04 '24 21:08 martinfrances107

Examples and benchmarks are excluded from the workspace and bumping the MSRV in the workspace is nonsense here. You may add MSRV to each example's Cargo.toml, not the workspace.

sabify avatar Aug 05 '24 08:08 sabify

You may add MSRV to each example's Cargo.toml, not the workspace.

Ok ... change is comming

martinfrances107 avatar Aug 05 '24 09:08 martinfrances107

you might want to hold off on the merge conflict resolution until we get a consensus about upgrading MSRV

Understood - It only took me a short time to reconstruct the PR .. force push is comming

martinfrances107 avatar Aug 28 '24 20:08 martinfrances107

I don't see a problem with doing this, especially for 0.7 as a major release. We don't really have a stated MSRV policy. Appreciate you taking the time @martinfrances107

benwis avatar Sep 20 '24 04:09 benwis