webextension-pixiv-toolkit icon indicating copy to clipboard operation
webextension-pixiv-toolkit copied to clipboard

Non-Latin symbols causes naming error

Open Heralda opened this issue 2 years ago • 0 comments

First Thank you for making this amazing extension!

Bug If an author, title etc. contains non-Latin letters or symbols, that part of the filename/folder is replaced by the text {title}, {author} etc.

Expected behavior In app settings, you can select an automatic name for a file or folder based on author etc. If the download path is set to {author}/, and the author is "Example", the file is downloaded to Example\

Actual behavior If the string contains only English Latin letters, this works perfectly. But when it contains other letters such as Japanese symbols, the file is instead saved to {author}\ Author "Example" is downloaded to the folder Example\ Author "例" is downloaded to the folder {author}\

Example https://www.pixiv.net/en/artworks/107634753 is downloaded to the incorrect folder. image

Browser: 112.0.2 (64-bit)

Settings: {"MangaPageNumberStartWithOne":false,"alwaysPack":true,"animationJsonFormat":0,"askDownloadSavedWork":true,"autoActivateDownloadPanel":false,"disableDownloadsShelf":false,"displayWorkTypeLabel":true,"downloadPackFiles":false,"downloadPanelPosition":"left","downloadPanelStyle":1,"downloadRelativeLocation":"{author}/","downloadSaveAs":true,"downloadTasksWhenDownloadingImages":3,"enableExtTakeOverDownloads":true,"enableExtend":false,"enableExtension":true,"enablePackUgoiraFramesInfo":true,"enablePtkSearch":true,"enableSaveDownloadHistory":1,"enableSaveVisitHistory":true,"enableWhenUnderSeconds":1,"extendDuration":3,"featureKnown":false,"guideShowed":true,"illustrationCreateSubdirectory":0,"illustrationImageRenameFormat":"{pageNum}","illustrationKeepPageNumber":false,"illustrationPageNumberLength":-1,"illustrationPageNumberStartWithOne":true,"illustrationRelativeLocation":"","illustrationRenameFormat":"{pageNum}","importantNoticeDisplayed":true,"language":"default","mangaImageRenameFormat":"{pageNum}","mangaPageNumberLength":-1,"mangaPageNumberStartWithOne":true,"mangaPagesInChunk":99,"mangaRelativeLocation":"","mangaRenameFormat":"{pageNum}","maxDownloadRecords":10000,"maxHistoryItems":"10000","multipleDownloadsGapTime":150,"notSaveNSFWWorkInHistory":false,"novelIncludeDescription":true,"novelRelativeLocation":"","novelRenameFormat":"{pageNum}","pixivComicImageRenameFormat":"{pageNum}","pixivComicPageNumberLength":-1,"pixivComicPageNumberStartWithOne":false,"pixivComicRelativeLocation":"","pixivComicRenameFormat":"{pageNum}","showPixivOmina":true,"showReloadInPopup":false,"showUpdateChangeLog":false,"statIllustDownloaded":5,"statMangaDownloaded":0,"statNovelDownloaded":0,"statUgoiraDownloaded":9,"ugoiraConvertTool":"default","ugoiraCustomFFmpegCommand":"","ugoiraQuanlity":1,"ugoiraRelativeLocation":"{author}/","ugoiraRenameFormat":"{pageNum}","version":"5.5.3","visitHistoryType":"list","workCoverSize":1}

OS: Win 10 64-bit

Heralda avatar May 01 '23 13:05 Heralda