angular-chosen icon indicating copy to clipboard operation
angular-chosen copied to clipboard

Abandon coffeescript in favor of ES6

Open VanTanev opened this issue 7 years ago • 5 comments

I propose rewriting the module in ES6 for version 2.0 Honestly, dealing with coffee script is a bigger distraction than it's worth.

VanTanev avatar Sep 27 '18 22:09 VanTanev

I totally agree. IMO I never really liked coffeescript. It was more just a challenge.

Happy to use es6 or TS. But TS will be confused with Angular 2-6

leocaseiro avatar Sep 27 '18 22:09 leocaseiro

It would be great to be able to use chosen with es6 modules. Will you rewrite it by chance?

andresgardiol avatar Mar 14 '19 14:03 andresgardiol

@andresgardiol angular-chosen is separate from chosen-js. Even if we rewrote angular-chosen to be compatible with what you mean to be (I assume) browser es6 modules, chosen-js itself is not, and we cannot rewrite it.

However, even the current version of both angular-chosen and chosen-js are compatible with es6 imports, as handled by WebPack.

VanTanev avatar Mar 14 '19 14:03 VanTanev

Thanks for your answer. Can you tell me how you import angular-chosen module with es6? I had some problems to do so.

andresgardiol avatar Mar 14 '19 14:03 andresgardiol

This really isn't the place, but 1 short example

import 'jquery'
import 'chosen-js'
import 'angular-chosen-localytics'
import angular from 'angular'

angular.module('app', ['localytics.directives'])

VanTanev avatar Mar 14 '19 14:03 VanTanev