FastPFor icon indicating copy to clipboard operation
FastPFor copied to clipboard

Published 20 hours ago • verified publisher icon lemire

Implemented packaging using CPack

Open KOLANICH opened this issue 4 years ago • 7 comments

KOLANICH avatar Jun 28 '21 09:06 KOLANICH

This PR breaks the build under Visual Studio 2017, see CI tests...

LINK : fatal error LNK1104: cannot open file 'Debug\FastPFOR.lib' [C:\projects\fastpfor\build\FastPFOR_unittest.vcxproj]

lemire avatar Jun 28 '21 12:06 lemire

@KOLANICH Please sync with the main branch. I have switched the CI tests to run with the Release version of the code. The tests should run much faster.

lemire avatar Jun 28 '21 20:06 lemire

Hmm, it is definitely not timeout, but something else.

KOLANICH avatar Jun 28 '21 20:06 KOLANICH

@KOLANICH The error indicates that the DLL is not found.

lemire avatar Jun 28 '21 20:06 lemire

With a static build (the default in CMake), the library is included in the binaries. With a dynamic build, a distinct file (e.g., a DLL) is created in addition to the binary executable. In a portable way, one must then ensure that when the binary run, the dynamic library is found. This requires extra care.

lemire avatar Jun 29 '21 23:06 lemire

I'm sorry, IDK what is wrong. For me (Windows 7, 32-bit, core2duo CPU (conroe, no avx, only sse3), MSYS2 MinGW-w64 + clang-12) everything builds (though there are issues with -lpthread not being added, I have tried to add it into PUBLIC dependencies of libfastpfor without much success (helped only for some libs), it helped to add it into all the exes, but I don't understand why I should do it and I don't think that that patch should go here).

Also: on my configuration the second test fails with reports of wrong answers.

KOLANICH avatar Oct 08 '21 12:10 KOLANICH

@KOLANICH Please review our CI logs. We have two independent Windows CI tests and this PR fails both of them.

Note that building is not sufficient, we need to run the tests successfully.

lemire avatar Oct 08 '21 16:10 lemire