Larry Gregory

Results 66 comments of Larry Gregory
trafficstars

Yep, I think those typedefs would end up working for this. We'd just need to re-publish under `@types/rison-node`, or include those typedefs directly in this repository. I prefer the latter...

> Implement Pytest Snapshot functionality and convert most (if not all) document reference comparisons to just using snapshots If we plan to eventually contribute this upstream to Home Assistant, then...

I like this proposal, I'd be happy to see us take this approach. https://github.com/legrego/homeassistant-elasticsearch/pull/272 is already massive, so let's wait for that to merge before taking this on.

> Included option 2 in #290 I'm good with this approach, thanks.

> Are we ok with making HA 2024.4.2 and Python 3.12 the minimum version for the project? Yes, this would have to be a prerequisite. I'm less worried about bumping...

Why do you want to remove the no-auth option?

Yeah understood (I worked on that 🙂). I expect most run with auth, but it feels like a cheap enough feature to leave in for those who don't. ++ to...

I'm also interested in having support for the `Partitioned` attribute. What are our next steps for this, @kanongil?

Thanks for expressing your interest, @salmin89, and do let me know how you make out with your test!

@salmin89, happy to hear that. > If you don't get any response, are there any plans on publishing your package as a standalone solution? We are discussing this as an...