cpp_box icon indicating copy to clipboard operation
cpp_box copied to clipboard

Increase test coverage, addresses #7

Open rseyyedi opened this issue 7 years ago • 5 comments

1st try to make a test case

rseyyedi avatar Sep 30 '18 17:09 rseyyedi

Codecov Report

Merging #9 into master will increase coverage by 1.75%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #9      +/-   ##
=========================================
+ Coverage   75.45%   77.2%   +1.75%     
=========================================
  Files           2       2              
  Lines         440     430      -10     
=========================================
  Hits          332     332              
+ Misses        108      98      -10
Impacted Files Coverage Δ
test/constexpr_tests.cpp 100% <100%> (ø) :arrow_up:
include/cpp_box/arm.hpp 69.56% <0%> (+3.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2add388...d0569f0. Read the comment docs.

codecov[bot] avatar Sep 30 '18 17:09 codecov[bot]

2nd Try

rseyyedi avatar Oct 03 '18 12:10 rseyyedi

constexpr_tests.cpp:24:3: in 'constexpr' expansion of '#'result_decl' not supported by dump_expr# <expression error>cpp_box::arm::System<1024, std::array<unsigned char, 1024> >::process(instruction#7)'

include/cpp_box/arm.hpp:47:45: error: right operand of shift expression '(0 >> 4294967292)' is >= than the precision of the left operand [-fpermissive] return val & (static_cast<Value>(1) << bit);

rseyyedi avatar Oct 03 '18 12:10 rseyyedi

Looks like a start - just need to actually verify that it did what you wanted it to do with some test other than it just executing.

lefticus avatar Oct 09 '18 02:10 lefticus

Looks like a start - just need to actually verify that it did what you wanted it to do with some test other than it just executing.

Yeah, I was reading what would happen to registers after memory manipulation and what to check.

rseyyedi avatar Oct 12 '18 07:10 rseyyedi