ios-cmake icon indicating copy to clipboard operation
ios-cmake copied to clipboard

libpng fails on OS64 with missing NEON detection option

Open AJenbo opened this issue 3 years ago • 4 comments

This might be related to erroneous feature detection

AJenbo avatar Dec 01 '21 21:12 AJenbo

Hi! Did you solve this? I saw that the PR mentioned in the other issue had it's version of libPNG upped and I just wonder if that was due to issued in the libPNG buildchain or with this toolchain?

leetal avatar Jan 08 '22 06:01 leetal

we ended up forcing it with a flag

AJenbo avatar Jan 08 '22 07:01 AJenbo

Ah okay. So was there an actual issue with this toolchain or libPNG itself? I have actually managed to build libPNG a couple of years ago for iOS and back then, libPNG lacked support for the correct runtime checks of NEON on iOS. Only Android & Linux had implemented runtime checks. Back then, if i recall correctly, specifying -DPNG_ARM_NEON=on was sufficient (since all ARM SoCs since at least armv6 has support for NEON out of the box).

leetal avatar Jan 08 '22 07:01 leetal

Yeah that is the solution we ended up with as well, I wonder if there is a way to detect this automatically?

AJenbo avatar Jan 08 '22 08:01 AJenbo