Lee Powell

Results 48 comments of Lee Powell

I'm not getting an error on this, but limit and offset seem to have been swapped - offset now limits and limit now offsets.

Think I have a simple fix. Just need to test it, then I'll submit a PR.

@mdjastrzebski a single promise passes, mutiple promises fails. I don't believe this is a problem with timeouts, but possibly an issue with the promises... I tried changing the `wait` util...

:+1: - the theme looks odd with the large indent and no supporting file icons. I think the icons found in Sublimes default theme would look good with this.

OK, adding the second argument seemed to fix - however we still can't seem to satisfy this rule using a `htmlFor` and `id` to create a relationship. For example, we...

It has to have both? So this rule doesn't support related labels/controls via id/for only?

Ideally I'd like to configure it for either scenario, nested, both or ID's... I'm struggling to see how I configure it to support ID's. I'd love to support doing both,...

Out of interest - if an input is wrapped in a label, why does it also need the for/ID? Are there some browsers / assistive devices that don't create a...

Thanks. Just looks through the source code - I can't see any configuration options for `assert` as per the `label-has-associated-control` rule. So I'm not sure it's possible to configure to...

Yes that’s for ‘label-has-associated-control’, not ‘control-has-associated-label’ which is what I’m talking about 🙂 > On 15 Mar 2019, at 21:26, Jordan Harband wrote: > > See assert here: > >...