designcourse
designcourse copied to clipboard
👷♀️ [Devx] Make developer extension queries compatible with exclusion
Motivation
Current filter queries do not support exclusion, despite that we support this mode in the filters. It would also be nice to update the query while selecting with facets.
Changes
- Added exclusion mode support in query parsing
- Added more tests for events filter
- Made selections in facets update the search queries (but not vice versa yet)
Testing
- [x] Local
- [ ] Staging
- [x] Unit
- [ ] End to end
I have gone over the contributing documentation.
Codecov Report
Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 93.19%. Comparing base (
5948bd8) to head (1756878). Report is 3 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...xtension/src/panel/hooks/useEvents/eventFilters.ts | 97.77% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #3434 +/- ##
==========================================
+ Coverage 92.73% 93.19% +0.46%
==========================================
Files 301 302 +1
Lines 7900 7941 +41
Branches 1807 1819 +12
==========================================
+ Hits 7326 7401 +75
+ Misses 574 540 -34
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Bundles Sizes Evolution
| 📦 Bundle Name | Base Size | Local Size | 𝚫 | 𝚫% | Status |
|---|---|---|---|---|---|
| Rum | 144.57 KiB | 144.57 KiB | 0 B | 0.00% | ✅ |
| Logs | 51.37 KiB | 51.37 KiB | 0 B | 0.00% | ✅ |
| Rum Slim | 106.00 KiB | 106.00 KiB | 0 B | 0.00% | ✅ |
| Worker | 23.59 KiB | 23.59 KiB | 0 B | 0.00% | ✅ |
🚀 CPU Performance
| Action Name | Base Average Cpu Time (ms) | Local Average Cpu Time (ms) | 𝚫 |
|---|---|---|---|
| addglobalcontext | 0.003 | 0.003 | -0.000 |
| addaction | 0.043 | 0.073 | 0.030 |
| addtiming | 0.001 | 0.002 | 0.001 |
| adderror | 0.049 | 0.084 | 0.035 |
| startstopsessionreplayrecording | 0.019 | 0.040 | 0.022 |
| startview | 0.477 | 0.650 | 0.174 |
| logmessage | 0.021 | 0.026 | 0.005 |
🧠 Memory Performance
| Action Name | Base Consumption Memory (bytes) | Local Consumption Memory (bytes) | 𝚫 (bytes) |
|---|---|---|---|
| addglobalcontext | 25.68 KiB | 25.81 KiB | 139 B |
| addaction | 52.64 KiB | 54.64 KiB | 2.00 KiB |
| addtiming | 25.18 KiB | 24.93 KiB | -259 B |
| adderror | 57.60 KiB | 56.95 KiB | -657 B |
| startstopsessionreplayrecording | 24.57 KiB | 24.49 KiB | -76 B |
| startview | 418.24 KiB | 419.30 KiB | 1.06 KiB |
| logmessage | 52.59 KiB | 53.13 KiB | 545 B |