designcourse icon indicating copy to clipboard operation
designcourse copied to clipboard

⚗ [RUM-7213] DOM mutation ignoring

Open jordan-th opened this issue 10 months ago • 5 comments

Motivation

Ability to exclude certain DOM mutations from affecting the page loading time calculation

Changes

  • attributes mutations are ignored if the element has the attribute dd-ignore-mutations
  • childList and characterData mutations are ignored if the parent element has the attribute dd-ignore-mutations

Testing

  • [x] Local
  • [ ] Staging
  • [x] Unit
  • [ ] End to end

I have gone over the contributing documentation.

jordan-th avatar Jan 11 '25 01:01 jordan-th

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Jan 11 '25 01:01 bits-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.24%. Comparing base (2c55093) to head (ba9a760). Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3276      +/-   ##
==========================================
+ Coverage   92.22%   92.24%   +0.01%     
==========================================
  Files         313      313              
  Lines        8041     8057      +16     
  Branches     1815     1824       +9     
==========================================
+ Hits         7416     7432      +16     
  Misses        625      625              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jan 13 '25 18:01 codecov-commenter

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 145.54 KiB 145.54 KiB N/A%
Rum Recorder 0 B 18.02 KiB 18.02 KiB N/A%
Rum Profiler 0 B 4.73 KiB 4.73 KiB N/A%
Logs 0 B 49.97 KiB 49.97 KiB N/A%
Rum Slim 0 B 105.17 KiB 105.17 KiB N/A%
Worker 0 B 23.59 KiB 23.59 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.003 0.003
addaction N/A 0.063 0.063
addtiming N/A 0.001 0.001
adderror N/A 0.045 0.045
startstopsessionreplayrecording N/A 0.015 0.015
startview N/A 0.489 0.489
logmessage N/A 0.026 0.026
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 26.46 KiB NaN KiB
addaction NaN KiB 55.38 KiB NaN KiB
addtiming NaN KiB 25.19 KiB NaN KiB
adderror NaN KiB 58.57 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 22.92 KiB NaN KiB
startview NaN KiB 429.36 KiB NaN KiB
logmessage NaN KiB 52.11 KiB NaN KiB

🔗 RealWorld

cit-pr-commenter[bot] avatar Jan 13 '25 18:01 cit-pr-commenter[bot]

/to-staging

jordan-th avatar Jan 13 '25 18:01 jordan-th

Devflow running: /to-staging

View all feedbacks in Devflow UI.


2025-01-13 18:14:12 UTC :information_source: Branch Integration: starting soon, median merge time is 0s

Commit 75388df806 will soon be integrated into staging-03.


2025-01-13 18:25:08 UTC :information_source: Branch Integration: This commit was successfully integrated

Commit 75388df806 has been merged into staging-03 in merge commit 07047d13b3.

Check out the triggered pipeline on Gitlab :fox_face:

dd-devflow[bot] avatar Jan 13 '25 18:01 dd-devflow[bot]

View all feedbacks in Devflow UI.

2025-05-14 08:28:15 UTC :information_source: Start processing command /to-staging --cancel If you need support, contact us on Slack #devflow!


2025-05-14 08:28:18 UTC :x: Devflow: /to-staging --cancel

Cannot cancel integration of e263f47d7a into staging-20:

This merge request is not in the queue and can't be unqueued

To get help about command usage, write /to-staging --help

If you need support, contact us on Slack #devflow with those details!

dd-devflow[bot] avatar May 14 '25 08:05 dd-devflow[bot]

/to-staging

BenoitZugmeyer avatar May 14 '25 08:05 BenoitZugmeyer

View all feedbacks in Devflow UI.

2025-05-14 08:28:32 UTC :information_source: Start processing command /to-staging


2025-05-14 08:28:42 UTC :information_source: Branch Integration: starting soon, merge expected in approximately 20m53s (p90)

Commit e263f47d7a will soon be integrated into staging-20.


2025-05-14 08:45:33 UTC :information_source: Branch Integration: This commit was successfully integrated

Commit e263f47d7a has been merged into staging-20 in merge commit 3c1ac20737.

Check out the triggered pipeline on Gitlab :fox_face:

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-20

dd-devflow[bot] avatar May 14 '25 08:05 dd-devflow[bot]

/merge

BenoitZugmeyer avatar May 19 '25 09:05 BenoitZugmeyer

View all feedbacks in Devflow UI.

2025-05-19 09:58:49 UTC :information_source: Start processing command /merge


2025-05-19 09:58:56 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.


2025-05-19 13:04:16 UTC :warning: MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

dd-devflow[bot] avatar May 19 '25 09:05 dd-devflow[bot]

/to-staging

BenoitZugmeyer avatar May 19 '25 10:05 BenoitZugmeyer

View all feedbacks in Devflow UI.

2025-05-19 10:21:41 UTC :information_source: Start processing command /to-staging


2025-05-19 10:21:51 UTC :information_source: Branch Integration: starting soon, merge expected in approximately 12m44s (p90)

Commit ba9a760ce3 will soon be integrated into staging-21.


2025-05-19 10:22:06 UTC :rotating_light: Branch Integration: this merge request has conflicts which couldn't be solved automatically

We couldn't automatically merge the commit ba9a760ce3 into staging-21!

To solve the conflicts directly in Github, click here to create a fix pull request.

Alternatively, you can also click here reset the integration branch or use the following Slack command: /devflow reset-branch -r browser-sdk -b staging-21

dd-devflow[bot] avatar May 19 '25 10:05 dd-devflow[bot]

:steam_locomotive: Branch Integration: starting soon, merge expected in approximately 12m44s (p90)

Commit ba9a760ce3 will soon be integrated into staging-21.

dd-devflow[bot] avatar May 19 '25 11:05 dd-devflow[bot]

:steam_locomotive: Branch Integration

Commit ba9a760ce3 has been merged into staging-21 in merge commit 9df8001295.

Check out the triggered pipeline on Gitlab :fox_face:

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-21

dd-devflow[bot] avatar May 19 '25 12:05 dd-devflow[bot]

/merge

BenoitZugmeyer avatar May 19 '25 13:05 BenoitZugmeyer

View all feedbacks in Devflow UI.

2025-05-19 13:03:55 UTC :information_source: Start processing command /merge


2025-05-19 13:03:57 UTC :x: MergeQueue

PR already in the queue with status waiting

dd-devflow[bot] avatar May 19 '25 13:05 dd-devflow[bot]

/remove

BenoitZugmeyer avatar May 19 '25 13:05 BenoitZugmeyer

View all feedbacks in Devflow UI.

2025-05-19 13:04:11 UTC :information_source: Start processing command /remove


2025-05-19 13:04:14 UTC :information_source: Devflow: /remove

dd-devflow[bot] avatar May 19 '25 13:05 dd-devflow[bot]

/merge

BenoitZugmeyer avatar May 19 '25 13:05 BenoitZugmeyer

View all feedbacks in Devflow UI.

2025-05-19 13:04:55 UTC :information_source: Start processing command /merge


2025-05-19 13:05:02 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.


2025-05-19 14:22:37 UTC :information_source: MergeQueue: This merge request was already merged

This pull request was merged directly.

dd-devflow[bot] avatar May 19 '25 13:05 dd-devflow[bot]