designcourse icon indicating copy to clipboard operation
designcourse copied to clipboard

[RUM 4813] Remove feature flag for view specific context

Open cy-moi opened this issue 1 year ago • 2 comments

Motivation

Make view specific context apis public without experimental feature flag.

Changes

Removed feature flag and set APIs public by defualt.

Testing

  • [x] Local
  • [ ] Staging
  • [x] Unit
  • [x] End to end

I have gone over the contributing documentation.

cy-moi avatar Sep 23 '24 14:09 cy-moi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.36%. Comparing base (8baa800) to head (c8b0ecb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
- Coverage   93.37%   93.36%   -0.01%     
==========================================
  Files         276      276              
  Lines        7649     7643       -6     
  Branches     1717     1712       -5     
==========================================
- Hits         7142     7136       -6     
  Misses        507      507              
Flag Coverage Δ
93.36% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 24 '24 12:09 codecov-commenter

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.95 KiB 161.77 KiB -182 B -0.11%
Logs 56.03 KiB 55.99 KiB -48 B -0.08%
Rum Slim 110.52 KiB 110.34 KiB -182 B -0.16%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.003 0.001
addaction 0.048 0.073 0.024
addtiming 0.001 0.001 0.000
adderror 0.045 0.062 0.016
startstopsessionreplayrecording 1.350 1.876 0.526
startview 1.201 2.170 0.969
logmessage 0.028 0.046 0.018
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.59 KiB 7.73 KiB 135 B
addaction 38.60 KiB 38.57 KiB -30 B
addtiming 6.20 KiB 6.27 KiB 74 B
adderror 43.97 KiB 44.89 KiB 939 B
startstopsessionreplayrecording 5.77 KiB 3.95 KiB -1863 B
startview 437.46 KiB 443.75 KiB 6.29 KiB
logmessage 39.89 KiB 39.82 KiB -70 B

🔗 RealWorld

cit-pr-commenter[bot] avatar Sep 24 '24 12:09 cit-pr-commenter[bot]