designcourse
designcourse copied to clipboard
♻️ [RUM-6278] Use performance observer for layout shift entries
Motivation
Following the introduction of performanceObservable to move away from performanceCollection: PR
Let use performanceObservable for layout shift and event entries.
Changes
- Remove
performanceCollection - Use
perfomanceObservableintrackCumulativeLayoutShift
Testing
- [x] Local
- [x] Staging
- [x] Unit
- [ ] End to end
I have gone over the contributing documentation.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.21%. Comparing base (
365ee74) to head (6f59fd1). Report is 638 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
- Coverage 93.37% 93.21% -0.17%
==========================================
Files 276 275 -1
Lines 7649 7616 -33
Branches 1717 1712 -5
==========================================
- Hits 7142 7099 -43
- Misses 507 517 +10
| Flag | Coverage Δ | |
|---|---|---|
93.21% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Bundles Sizes Evolution
| 📦 Bundle Name | Base Size | Local Size | 𝚫 | 𝚫% | Status |
|---|---|---|---|---|---|
| Rum | 0 B | 161.09 KiB | 161.09 KiB | N/A% | ✅ |
| Logs | 0 B | 56.03 KiB | 56.03 KiB | N/A% | ✅ |
| Rum Slim | 0 B | 109.66 KiB | 109.66 KiB | N/A% | ✅ |
| Worker | 0 B | 25.21 KiB | 25.21 KiB | N/A% | ✅ |
🚀 CPU Performance
| Action Name | Base Average Cpu Time (ms) | Local Average Cpu Time (ms) | 𝚫 |
|---|---|---|---|
| addglobalcontext | N/A | 0.003 | 0.003 |
| addaction | N/A | 0.069 | 0.069 |
| addtiming | N/A | 0.001 | 0.001 |
| adderror | N/A | 0.072 | 0.072 |
| startstopsessionreplayrecording | N/A | 2.550 | 2.550 |
| startview | N/A | 2.587 | 2.587 |
| logmessage | N/A | 0.040 | 0.040 |
🧠 Memory Performance
| Action Name | Base Consumption Memory (bytes) | Local Consumption Memory (bytes) | 𝚫 (bytes) |
|---|---|---|---|
| addglobalcontext | NaN KiB | 9.05 KiB | NaN KiB |
| addaction | NaN KiB | 39.88 KiB | NaN KiB |
| addtiming | NaN KiB | 6.66 KiB | NaN KiB |
| adderror | NaN KiB | 45.38 KiB | NaN KiB |
| startstopsessionreplayrecording | NaN KiB | 4.68 KiB | NaN KiB |
| startview | NaN KiB | 425.96 KiB | NaN KiB |
| logmessage | NaN KiB | 39.19 KiB | NaN KiB |
/to-staging
:steam_locomotive: Branch Integration: starting soon, median merge time is 9m
Commit 6f59fd1d86 will soon be integrated into staging-38.
Use /to-staging -c to cancel this operation!
:steam_locomotive: Branch Integration: This commit was successfully integrated
Commit 6f59fd1d86 has been merged into staging-38 in merge commit f1e7a172b1.
/to-staging
:steam_locomotive: Branch Integration: starting soon, median merge time is 0s
Commit 6f59fd1d86 will soon be integrated into staging-39.
Use /to-staging -c to cancel this operation!
:steam_locomotive: Branch Integration: This commit was successfully integrated
Commit 6f59fd1d86 has been merged into staging-39 in merge commit ab36adf564.
We're seeing a big increase in CLS scores in some parts of our app. Is it possible this change could result in an increase in CLS scores?