no-response icon indicating copy to clipboard operation
no-response copied to clipboard

Published 20 hours ago • verified publisher icon lee-dohm

Support PRs

Open triallax opened this issue 4 years ago • 5 comments

I took a quick look at the code and it seems like it does, but just to be sure, should this action also work with PRs? If it does, then I believe the default comment should also account for PRs instead of only issues. Also, would there be anything against allowing having a different daysUntilClose for PRs?

I would be willing to open PRs for the above changes.

triallax avatar Jul 26 '21 23:07 triallax

Judging by https://github.com/lee-dohm/no-response/blob/1ae4f8bbc8a4607bb904abc1f5f7556ea2ace95b/src/no-response.ts#L133-L138, it does check both issues and PRs.

native-api avatar Oct 01 '21 01:10 native-api

Well, if you go a couple lines up: https://github.com/lee-dohm/no-response/blob/1ae4f8bbc8a4607bb904abc1f5f7556ea2ace95b/src/no-response.ts#L130

It filters out PRs.

triallax avatar Oct 01 '21 06:10 triallax

Then you've answered your own question :slightly_smiling_face:

native-api avatar Oct 01 '21 12:10 native-api

Haha, fair enough, but I'll keep this open as an issue that requests PR support.

triallax avatar Oct 01 '21 12:10 triallax

oh dang, I wanted this mostly for PRs :\

ryanflorence avatar Feb 11 '22 05:02 ryanflorence